Michael Ho has posted comments on this change. Change subject: IMPALA-4883: Union Codegen ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6459/7/be/src/exec/union-node-ir.cc File be/src/exec/union-node-ir.cc: PS7, Line 34: t_batch->CommitLast Is this not used at all ? PS7, Line 45: There is a macro called FOREACH_ROW() which is useful for iterating through rows in a row batch. It will save some cycles as it avoids the multiplication in GetRow(). http://gerrit.cloudera.org:8080/#/c/6459/1/be/src/exec/union-node.h File be/src/exec/union-node.h: PS1, Line 71: tuple_pool_; > Michael, do you think it makes sense to use this approach for now? I'm not I agree that we should not mix in the fix for CodegenMaterializeExprs() in this patch. We probably need to fix other places such as TopNNode. -- To view, visit http://gerrit.cloudera.org:8080/6459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4107d27582ff5416172810364a6e76d3d93c439 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
