Dan Hecht has posted comments on this change. Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet ......................................................................
Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/5939/8/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: PS8, Line 601: . ... in 'scanner_status'. PS8, Line 604: Status& scanner_status please pass this as a 'Status* scanner_status', which is what we usually do for out parameters to make it more obvious at the callsite that it's modified. And nice to put out parameters last. http://gerrit.cloudera.org:8080/#/c/5939/8/be/src/runtime/timestamp-value.cc File be/src/runtime/timestamp-value.cc: PS8, Line 124: local_date_time lt(temp, timezone); can this throw an exception? PS8, Line 125: *this = lt.local_time(); or that? http://gerrit.cloudera.org:8080/#/c/5939/8/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS8, Line 122: HDFS it's the same for other FileSystem interfaced things, like S3. So maybe remove "HDFS". -- To view, visit http://gerrit.cloudera.org:8080/5939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f24525ef45a2814f476bdee76655b30081079d6 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-HasComments: Yes
