Zach Amsden has posted comments on this change. Change subject: IMPALA-5180: Don't use non-deterministic exprs in partition pruning ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/6575/9/fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java File fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java: Line 112: !conjunct.contains(Expr.IS_NONDETERMINISTIC_BUILTIN_FN_PREDICATE)) { Since we ignore these predicates here, they still get attached to the plan node - resulting in this: Failed tests: PlannerTest.testHdfs:96->PlannerTestBase.runPlannerTestFile:764->PlannerTestBase.runPlannerTestFile:759 Expected failure, but query produced PLAN. Query: select * from functional.alltypes where rand() > year PLAN: PLAN-ROOT SINK | 00:SCAN HDFS [functional.alltypes] partitions=24/24 files=24 size=478.45KB predicates: year < rand() So we can actually evaluate randomized predicates now, they just aren't used for partition filtering. Do we actually want to do that? -- To view, visit http://gerrit.cloudera.org:8080/6575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91054c6bf017401242259a1eff5e859085285546 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
