Zach Amsden has posted comments on this change. Change subject: IMPALA-5180: Don't balk at non-deterministic exprs ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/6575/3/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: Line 1029: public boolean isBoundByTupleIds(List<TupleId> tids) { > I thought about this a little more and I think fixing the isBound() functio While consistency is nice, I'd rather keep this fix small and contained. Line 1037: * Returns true if expr is fully bound by slotIds and contains at least > Not your change, but can you modify the comment to explain what "bound" mea Done Line 1045: HashSet<SlotId> idSet = Sets.newHashSet(); > idSet -> exprSlotIds Done Line 1046: int members = 0; > Why is this needed? Do you mean Preconditions.checkState(!exprSlotIds.isEmp I could just return false in that case, will probably be shorter and more concise. Line 1047: this.getIdsHelper(null, idSet); > remove 'this' Done -- To view, visit http://gerrit.cloudera.org:8080/6575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91054c6bf017401242259a1eff5e859085285546 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
