Alex Behm has posted comments on this change. Change subject: IMPALA-5180: Don't balk at non-deterministic exprs ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6575/3/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: Line 1029: public boolean isBoundByTupleIds(List<TupleId> tids) { > What about this? Our isBound() family of functions should be consistent. I thought about this a little more and I think fixing the isBound() functions in a consistent way may be quite difficult. My guess is that if you make corresponding changes to this function, then we end up not assigning the rand() predicate in your new tests. Addressing might be hard because our predicate assignment relies on isBound() (yes, it is already broken today in many ways for unbound, non-deterministic predicates). -- To view, visit http://gerrit.cloudera.org:8080/6575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91054c6bf017401242259a1eff5e859085285546 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
