Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5167: Use a single Kudu client across the BE ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6792/1/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: Line 77: : DataSink(row_desc), set client_ nullptr Line 148: DCHECK(client_ == NULL); use nullptr here and below http://gerrit.cloudera.org:8080/#/c/6792/1/bin/impala-config.sh File bin/impala-config.sh: Line 123: export IMPALA_KUDU_VERSION=98a5d37 we should keep the version bumps in their own changes in case we need to cherry pick the functionality to another branch later, which would have a different kudu version. how come the toolchain id doesn't change here? if you wait for my change to go in (https://gerrit.cloudera.org/#/c/6797/ ) it should include the change you need in Kudu as well -- To view, visit http://gerrit.cloudera.org:8080/6792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b0c12a256c33e8ef32315b3736cae2dea2ae705 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
