Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5167: Use a single Kudu client across the BE ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6792/1//COMMIT_MSG Commit Message: Line 15: can you add a comment about why it's OK to use the Kudu client in this way (assuming https://github.com/apache/kudu/commit/d07ecd6ded01201c912d2e336611a6a941f48d98 ) Line 22: how about validation that there are no correctness issues with concurrent usage? The case that's most interesting is when you have concurrent inserts + an add range ddl. If DanB's change isn't in Kudu, then this change will break in that scenario because the 'negative partition' cache in the kudu client will be wrong. -- To view, visit http://gerrit.cloudera.org:8080/6792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b0c12a256c33e8ef32315b3736cae2dea2ae705 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
