Dan Hecht has posted comments on this change. Change subject: IMPALA-5197: Erroneous corrupted Parquet file message ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6787/1/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: PS1, Line 56: every other call why? http://gerrit.cloudera.org:8080/#/c/6787/1/be/src/exec/parquet-column-readers.h File be/src/exec/parquet-column-readers.h: PS1, Line 293: 'val_count what is val_count? PS1, Line 294: TriggerDebugAction it's a bit tricky to follow what's happening since we use the same name "TriggerDebugAction" but they each seem to do things slightly differently. is there a better way to name these? -- To view, visit http://gerrit.cloudera.org:8080/6787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9138039ec60fbe9deff250b8772036e40e42e1f6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
