Tim Wood has posted comments on this change. Change subject: IMPALA-5197: Erroneous corrupted Parquet file message ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6787/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: Line 323: table_format=vector.get_value('table_format')) > Why pass the table format? Seems confusing/unnecessary. Do we want to do anything with 'result' here? Otherwise omit saving return? -- To view, visit http://gerrit.cloudera.org:8080/6787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9138039ec60fbe9deff250b8772036e40e42e1f6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Wood <tw...@cloudera.com> Gerrit-HasComments: Yes