Alex Behm has posted comments on this change.

Change subject: IMPALA-5197: Erroneous corrupted Parquet file message
......................................................................


Patch Set 1:

(1 comment)

I'm not really sure if the added complexity to the test infra is warranted, 
given this very specific issue. Have you tried looping test_cancellation.py to 
see if you can get the error message that way? If you can repro that way with a 
reasonable rate, then maybe we can check in that test that we don't see this 
warning?

http://gerrit.cloudera.org:8080/#/c/6787/1/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

Line 323:           table_format=vector.get_value('table_format'))
Why pass the table format? Seems confusing/unnecessary.


-- 
To view, visit http://gerrit.cloudera.org:8080/6787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9138039ec60fbe9deff250b8772036e40e42e1f6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-HasComments: Yes

Reply via email to