Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6849/1//COMMIT_MSG Commit Message: Line 9: Adds support in DDL for timestamps in Kudu range partition syntax. > It would be nice to have an example query here. Done http://gerrit.cloudera.org:8080/#/c/6849/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: Line 1915: public void TestAlterKuduTable() { > Add timestamp tests here I have EE tests for this because (a) I can verify that the conversion is handled correctly and (b) we don't have any tables in the functional schema that have a TS range predicate, so no tables that I can target here (the EE test creates the table). PS1, Line 2319: > whitespace Done -- To view, visit http://gerrit.cloudera.org:8080/6849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae409b6106c073b038940f0413ed9d5859daaeff Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
