Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6849/2/fe/src/main/java/org/apache/impala/analysis/RangePartition.java File fe/src/main/java/org/apache/impala/analysis/RangePartition.java: Line 55: private final List<Expr> lowerBound_; point out that lower/uppperbound contains literals of the target column type post-analysis, and that for timestamps those are kudu timestamp values (=longs) Line 62: private boolean isAnalyzed_; initialize inline? -- To view, visit http://gerrit.cloudera.org:8080/6849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae409b6106c073b038940f0413ed9d5859daaeff Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
