Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL ......................................................................
Patch Set 2: (2 comments) preliminary comments http://gerrit.cloudera.org:8080/#/c/6849/2//COMMIT_MSG Commit Message: Line 14: partition cast('2009-01-02 00:00:00' as timestamp) <= VALUES < hm, would be nice to do an implicit cast when you see a string but want a timestamp http://gerrit.cloudera.org:8080/#/c/6849/2/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: Line 174: partition cast('2009-01-02 00:00:00' as timestamp) <= VALUES < i forgot: does the code check for overlaps somewhere? -- To view, visit http://gerrit.cloudera.org:8080/6849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae409b6106c073b038940f0413ed9d5859daaeff Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-HasComments: Yes
