Jim Apple has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/7073/2//COMMIT_MSG Commit Message: PS2, Line 10: replacing Did you use a script to do a global replace in fe or did you pick-and-choose which ones to change? PS2, Line 10: LinkedHashMap I assume LinkedHashThing takes more memory than HashThing. Is this something w should be concerned about? PS2, Line 13: a long line PS2, Line 13: Java 7 and Java 8 OpenJDK or Oracle or both? http://gerrit.cloudera.org:8080/#/c/7073/2/testdata/workloads/functional-planner/queries/PlannerTest/order.test File testdata/workloads/functional-planner/queries/PlannerTest/order.test: Line 694: | pass-through-operands: all Are these plans functionally the same? If not, which one is better? http://gerrit.cloudera.org:8080/#/c/7073/2/testdata/workloads/functional-planner/queries/PlannerTest/tpch-nested.test File testdata/workloads/functional-planner/queries/PlannerTest/tpch-nested.test: Line 2411: predicates on o: !empty(o.o_lineitems), o_orderstatus = 'F' Does this difference show up also in the execution? If so, should we pick one of these predicates to go first based on selectivity? -- To view, visit http://gerrit.cloudera.org:8080/7073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad8e1dccec3a51293a109c420bd2b88b9d1e0625 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-HasComments: Yes
