Jim Apple has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7073/2//COMMIT_MSG Commit Message: PS2, Line 10: LinkedHashMap > Yes, LinkedHashThing has two references for the linked list, so it takes a I'm more concerned about the space than the speed. Maybe Dimitris has some thoughts? It might not move the needle much in the context of other recent memory-saving changes. http://gerrit.cloudera.org:8080/#/c/7073/2/testdata/workloads/functional-planner/queries/PlannerTest/tpch-nested.test File testdata/workloads/functional-planner/queries/PlannerTest/tpch-nested.test: Line 2411: predicates on o: !empty(o.o_lineitems), o_orderstatus = 'F' > My assumption was that we only do cost based ordering for join predicates a I think I don't quite understand - even if conjuncts are evaluated on materialized tuples, order could matter, yes? -- To view, visit http://gerrit.cloudera.org:8080/7073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad8e1dccec3a51293a109c420bd2b88b9d1e0625 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
