Tim Armstrong has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7073/2/testdata/workloads/functional-planner/queries/PlannerTest/order.test File testdata/workloads/functional-planner/queries/PlannerTest/order.test: Line 694: | pass-through-operands: all > I suspect the new one is better, since it skips the extra materialization s I'm confused why this changed at all. The number of pass through operators should be independent of the original order of the union branches (there's logic to reorder the branches, putting the passthrough ones first). Smells like there's a bug somewhere. Should maybe get Taras to have a look, since he added the passthrough logic. -- To view, visit http://gerrit.cloudera.org:8080/7073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad8e1dccec3a51293a109c420bd2b88b9d1e0625 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
