Tim Armstrong has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call ......................................................................
Patch Set 2: It seems worthwhile to avoid spurious retries for RPCs in general, but it seems like this doesn't robustly solve the problem of sending duplicate row batches - in general I don't think it's possible to determine whether the RPC was delivered or not. We could avoid duplicate batches entirely if we maintained a sequence number for each sender/receiver pair and included it in each batch. Then the receiver could detect and discard duplicate batches. -- To view, visit http://gerrit.cloudera.org:8080/7063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176975f2aa521d5be8a40de51067b1497923d09b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
