Michael Ho has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call ......................................................................
Patch Set 2: (3 comments) Thanks for the reviews. Michael Brown ran the stress test in the secure cluster over the weekend with this patch and he didn't find any wrong results so far. I also requested a stress test run with the non-secure cluster. For testing, I looked into the fault injection logic but didn't look into it in details. http://gerrit.cloudera.org:8080/#/c/7063/2/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: PS2, Line 252: else if > nit: avoid 'else' since previous block will return. Here and below. Done PS2, Line 253: <F, Request, Response> > can the compiler not figure out the specialization from the arguments? Done PS2, Line 285: // If it's not timeout exception, then the connection is broken, stop retrying. > Remove? Done -- To view, visit http://gerrit.cloudera.org:8080/7063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176975f2aa521d5be8a40de51067b1497923d09b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alan Choi <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
