Michael Ho has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7063/2/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: PS2, Line 262: Status(TErrorCode::RPC_GENERAL_ERROR, e.what()); Please note that this will start returning "RPC: SSL resource temporarily unavailable" error and possibly some other errors when the cluster is under stress. Previously, we would transparently retry the RPC (which isn't the right thing to do all the time). I would like to point this change of behavior out to reviewers to make sure that the risk is acceptable and it won't be causing escalations. -- To view, visit http://gerrit.cloudera.org:8080/7063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176975f2aa521d5be8a40de51067b1497923d09b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
