Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). ......................................................................
IMPALA-5282: Handle overflows in computeResourceProfile(). An overflow in computeResourceProfile() could lead to negative resource estimates which later lead to a failed Preconditions check. I went through the computeResourceProfile() implementation of all data sinks and plan nodes and changed the code to handle overflows. Testing: - Reproduced the issue locally with the DDL provided in the JIRA. I manually set huge NDV stats to trigger overflow. Change-Id: I8a83a76141853d3274f812e5a531f456e1b110b1 --- M fe/src/main/java/org/apache/impala/planner/ExchangeNode.java M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java M fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java M fe/src/main/java/org/apache/impala/planner/JoinNode.java M fe/src/main/java/org/apache/impala/planner/PlanFragment.java M fe/src/main/java/org/apache/impala/planner/PlanNode.java M fe/src/main/java/org/apache/impala/planner/SubplanNode.java M fe/src/main/java/org/apache/impala/planner/UnionNode.java M fe/src/main/java/org/apache/impala/service/Frontend.java 9 files changed, 24 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/7084/2 -- To view, visit http://gerrit.cloudera.org:8080/7084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8a83a76141853d3274f812e5a531f456e1b110b1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
