Tim Armstrong has posted comments on this change. Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). ......................................................................
Patch Set 3: Code-Review+1 The change looks good to me. It would be nice to have a regression test but it seems like that would require new infrastructure to similar the huge tables. -- To view, visit http://gerrit.cloudera.org:8080/7084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a83a76141853d3274f812e5a531f456e1b110b1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
