Alex Behm has posted comments on this change. Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7084/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: Line 1019: try { > We did rely on the estimates for admission control before when query mem li We are in agreement. For now, I feel pretty good about the computePerHostResources() with respect to overflow since I read all the code carefully. We should still have tests to not break it sometime later. I filed IMPALA-5440 to address the long-standing bug in test coverage. -- To view, visit http://gerrit.cloudera.org:8080/7084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a83a76141853d3274f812e5a531f456e1b110b1 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
