John Sherman has posted comments on this change. Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7061/2/be/src/transport/TSaslServerTransport.cpp File be/src/transport/TSaslServerTransport.cpp: PS2, Line 158: socket->setRecvTimeout(0); : socket->setSendTimeout(0); > perhaps a safer fix is to get the values before overwriting them on l150, t I initially planned to do that, but TSocket doesn't provide a way to get the previous timeout values. PS2, Line 158: socket->setRecvTimeout(0); : socket->setSendTimeout(0); > Do the timeouts in client-cache.cc lines 120-121 not get applied to TSSLSoc Since this is the TSaslServerTransport I do not think they get applied via the client-cache code. I think the client-cache code would set the timeout for the TSaslClientTransport. I did the initial investigation awhile ago on an older build of impala, but will re-investigate to make sure my assumption is still correct. -- To view, visit http://gerrit.cloudera.org:8080/7061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Sherman <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: John Sherman <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
