Henry Robinson has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call ......................................................................
Patch Set 4: (8 comments) Thanks for the tests, I think this looks a lot better. http://gerrit.cloudera.org:8080/#/c/7063/4/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: PS4, Line 298: std::stringstream ss; : ss << "client " << client_ << " unexpected exception: " : << e.what() << ", type=" << typeid(e).name(); : return ss.str(); nit: prefer Substitute() over stringstream http://gerrit.cloudera.org:8080/#/c/7063/4/be/src/testutil/fault-injection-util.cc File be/src/testutil/fault-injection-util.cc: PS4, Line 51: std remove std:: PS4, Line 67: if (target_rpc_type != RPC_TRANSMITDATA) return; maybe DCHECK? Otherwise could be confusing if this silently fails to work as expected. Line 77: } else { Isn't this branch supposed to be one level higher - when !is_send? http://gerrit.cloudera.org:8080/#/c/7063/4/be/src/testutil/fault-injection-util.h File be/src/testutil/fault-injection-util.h: PS4, Line 48: inject grammar ("injects delays" maybe?) PS4, Line 55: inject injects an exception in a specified http://gerrit.cloudera.org:8080/#/c/7063/4/tests/custom_cluster/test_rpc_exception.py File tests/custom_cluster/test_rpc_exception.py: PS4, Line 27: \ not needed PS4, Line 33: indent python two spaces, not four -- To view, visit http://gerrit.cloudera.org:8080/7063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176975f2aa521d5be8a40de51067b1497923d09b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alan Choi <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
