Michael Ho has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call ......................................................................
Patch Set 3: (2 comments) Will update the patch with new tests. http://gerrit.cloudera.org:8080/#/c/7063/3/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: PS3, Line 186: write() send() > As Henry mentioned, the retry is to handle transient failure. There are thr As discussed offline, this is matching three specific exception cases in write_partial(). EAGAIN is translated to a timeout which may not be safe for retry. http://gerrit.cloudera.org:8080/#/c/7063/3/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: PS3, Line 256: VLOG(1) > I think this trace and below one are redundant, the Status will log error, Yes, I was just preserving the pre-existing error logging we have in the code. We can assemble a stringstream instead and pass it to Status constructor. -- To view, visit http://gerrit.cloudera.org:8080/7063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176975f2aa521d5be8a40de51067b1497923d09b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alan Choi <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
