Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). ......................................................................
IMPALA-5282: Handle overflows in computeResourceProfile(). An overflow in computeResourceProfile() could lead to negative resource estimates which later lead to a failed Preconditions check. I went through the computeResourceProfile() implementation of all data sinks and plan nodes and changed the code to handle overflows. Testing: - Reproduced the issue locally with the DDL provided in the JIRA. I manually set huge NDV stats to trigger overflow. Change-Id: I8a83a76141853d3274f812e5a531f456e1b110b1 Reviewed-on: http://gerrit.cloudera.org:8080/7084 Reviewed-by: Alex Behm <[email protected]> Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/planner/ExchangeNode.java M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java M fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java M fe/src/main/java/org/apache/impala/planner/JoinNode.java M fe/src/main/java/org/apache/impala/planner/PlanFragment.java M fe/src/main/java/org/apache/impala/planner/PlanNode.java M fe/src/main/java/org/apache/impala/planner/SubplanNode.java M fe/src/main/java/org/apache/impala/planner/UnionNode.java 8 files changed, 19 insertions(+), 17 deletions(-) Approvals: Impala Public Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a83a76141853d3274f812e5a531f456e1b110b1 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong <[email protected]>
