Lars Volker has posted comments on this change. Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs ......................................................................
Patch Set 3: (2 comments) Apologies Sailesh for the messed up PS #2. In general I try to leave an additional comment when I think a PS is worth another look, but I should have marked it as bad. http://gerrit.cloudera.org:8080/#/c/7155/2/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: Line 253: lock_guard<mutex> l(*request_state->lock()); > You need to take request_state->lock() before the return here. Done Line 283: } > Same here. You need to take request_state->lock() before retrieving the que Done -- To view, visit http://gerrit.cloudera.org:8080/7155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4494fe3f933cc23841db0e7da407eec5650f2b5 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
