Dan Hecht has posted comments on this change. Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/7155/5/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: Line 253: lock_guard<mutex> l(*request_state->lock()); you could add a DCHECK() here that if query_state == EXCEPTION, then !query_status.ok(). That should help track down whether the bug is something different than originally thought. Line 299: lock_guard<mutex> l(*request_state->lock()); rather than retaking the lock here, you should remember the value of ok() from above. actually, though, since we print GetAnalysisWarnings() in between, I don't see why this line break logic is correct. -- To view, visit http://gerrit.cloudera.org:8080/7155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4494fe3f933cc23841db0e7da407eec5650f2b5 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
