Dan Hecht has posted comments on this change. Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs ......................................................................
Patch Set 6: (1 comment) This look correct to me, but let's see what the new failure is due to. http://gerrit.cloudera.org:8080/#/c/7155/6/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: Line 301: error_log_ss << request_state->coord()->GetErrorLog(); what does the error log look like without the double line break? the alternative would be to keep one or two newlines, but change the condition to if error_log_ss is empty or not (rather than checking the ok()). -- To view, visit http://gerrit.cloudera.org:8080/7155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4494fe3f933cc23841db0e7da407eec5650f2b5 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
