Tim Armstrong has posted comments on this change. Change subject: IMPALA-5481: Clarify RowDescriptor ownership ......................................................................
Patch Set 6: Code-Review+1 I don't feel strongly personally about the ref vs pointer thing. The const refs seemed ok to me but I guess this is more consistent with the other descriptors. -- To view, visit http://gerrit.cloudera.org:8080/7206 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fc39170f775581d406b6a97445046f508d8d75f Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
