Henry Robinson has posted comments on this change. Change subject: IMPALA-5481: Clarify RowDescriptor ownership ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7206/2/be/src/exec/data-sink.h File be/src/exec/data-sink.h: PS2, Line 82: static Status Create(ObjectPool* pool, const TPlanFragmentCtx& fragment_ctx, : const TPlanFragmentInstanceCtx& fragment_instance_ctx, : const RowDescriptor* row_desc, DataSink** sink); > May be I missed it but I don't see fragment-instance-state.cc in this diff. In that case DataSinkCreate() is called with an ExecNode::row_desc() parameter, which has changed to return a const RowDescriptor*, so there's no actual code changes. -- To view, visit http://gerrit.cloudera.org:8080/7206 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fc39170f775581d406b6a97445046f508d8d75f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
