Henry Robinson has posted comments on this change. Change subject: IMPALA-5481: Clarify RowDescriptor ownership ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7206/2/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: Line 184: const_cast<RowDescriptor*>(row_desc_)->ToThrift(&output_batch->row_tuples); ToThrift() can be const, so this cast is unnecessary. -- To view, visit http://gerrit.cloudera.org:8080/7206 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fc39170f775581d406b6a97445046f508d8d75f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
