Michael Ho has posted comments on this change. Change subject: IMPALA-5537: Retry RpcRecv on recv timeout exception for SSL connection ......................................................................
Patch Set 1: (1 comment) Henry, can you please see if the suggestion in thrift-util.cc makes sense ? http://gerrit.cloudera.org:8080/#/c/7229/1/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: PS1, Line 209: Called write on non-open socket" It seems that we still didn't handle the case of send failure for failed connection. Unfortunately, TSSLSocket.cpp returns a generic TTransportException::NOT_OPEN so it's hard to distinguish whether the exception is from SSL_write() or SSL_read(). A better solution would be to override all high level functions in ImpalaInternalServiceClient (similar to what we did for TransmitData()) and adds a flag to indicate the send part of an RPC is done. In this way, we can safely retry the entire RPC if the send part hasn't completed yet. -- To view, visit http://gerrit.cloudera.org:8080/7229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8243d4cac93c453e9396b0e24f41e147c8637b8c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
