Michael Ho has posted comments on this change. Change subject: IMPALA-5537: Retry RPC on somes exceptions with SSL connection ......................................................................
Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/catalog/catalog-service-client-wrapper.h File be/src/catalog/catalog-service-client-wrapper.h: Line 25: class CatalogServiceClientWrapper: public CatalogServiceClient { > nit: space before : Done http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: PS2, Line 207: || > Should this really be && ? Oops. Must have been messed up in some previous changes which I reverted. http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/runtime/backend-client.h File be/src/runtime/backend-client.h: Line 113: > nit: extra blank line. Done http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/runtime/client-cache-types.h File be/src/runtime/client-cache-types.h: PS2, Line 23: CatalogServiceClientWrapper > replace line 38 with this one. Done http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: PS2, Line 243: bool* retry_is_safe = NULL > let's not do it now, but I think we should get rid of this parameter in fav That's feasible but it would require passing in RuntimeState too to check for cancellation. PS2, Line 319: bool send_done = false; > nit: move inside try block Done http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/statestore/statestore-service-client-wrapper.h File be/src/statestore/statestore-service-client-wrapper.h: PS2, Line 28: > space really needed? here and below Done -- To view, visit http://gerrit.cloudera.org:8080/7229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8243d4cac93c453e9396b0e24f41e147c8637b8c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
