Michael Ho has posted comments on this change. Change subject: IMPALA-5537: Retry RPC on somes exceptions with SSL connection ......................................................................
Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/rpc/thrift-server-test.cc File be/src/rpc/thrift-server-test.cc: Line 104: ssl_client.iface()->RegisterSubscriber(resp, TRegisterSubscriberRequest(), &send_done); nit: long line. Line 119: ThriftClient<StatestoreServiceClientWrapper> ssl_client("localhost", port, "", NULL, true); nit: long line. Line 141: ThriftClient<StatestoreServiceClientWrapper> ssl_client("localhost", port, "", NULL, true); nit: long line Line 169: ThriftClient<StatestoreServiceClientWrapper> ssl_client("localhost", port, "", NULL, true); nit: long line Line 216: ssl_client.iface()->RegisterSubscriber(resp, TRegisterSubscriberRequest(), &send_done); nit: long line Line 222: ssl_client.iface()->RegisterSubscriber(resp, TRegisterSubscriberRequest(), &send_done); nit: long line http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: PS2, Line 209: "TTransportException: Transport not open" Note that this is what TTransportExcept::what() returns when the exception object was created with empty messages. http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/runtime/backend-client.h File be/src/runtime/backend-client.h: Line 113: nit: extra blank line. -- To view, visit http://gerrit.cloudera.org:8080/7229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8243d4cac93c453e9396b0e24f41e147c8637b8c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
