Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5240: Allow configuration of number of disk I/O threads based on disk type ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7232/1//COMMIT_MSG Commit Message: PS1, Line 7: IMPALA-5240: Allow configuration of number of disk I/O threads based : on disk type long line, please keep to 90chars Line 20: Tested manually. Unfortunately, there is no way using DiskIoMgr class did you see how we test num_threads_per_disk in disk-io-mgr-test ? it'd be good to do something similar. at a minimum setting both of the new vars to the same value to reproduce the same behavior we have, but exercising the new code paths. -- To view, visit http://gerrit.cloudera.org:8080/7232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I094aff3747104104fe0465d73dcdbef5d9892f7c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
