Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7232/1/be/src/runtime/disk-io-mgr.h File be/src/runtime/disk-io-mgr.h: PS1, Line 637: /// - threads_per_rotational_disk: number of read threads to create per rotational : /// disk. This is also the max queue depth. : /// - threads_per_flash_disk: number of read threads to create per flash disk. This is : /// also the max queue depth. : DiskIoMgr(int num_disks, int threads_per_disk, int min_buffer_size, : int max_buffer_size, int threads_per_rotational_disk = 0, : int threads_per_flash_disk = 0) > You can remove threads_per_disk and instead change the tests to pass the sa You can also change DiskQueue to know how many threads it has, and update DiskIoMgr::DebugString() to include that info in the output when it iterates over the DiskQueues. That'd be easy to check from the test. -- To view, visit http://gerrit.cloudera.org:8080/7232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I094aff3747104104fe0465d73dcdbef5d9892f7c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
