Michael Ho has posted comments on this change. Change subject: IMPALA-5537: Retry RPC on somes exceptions with SSL connection ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: PS2, Line 208: // "TTransportException: Transport not open" is from TSSLSocket.cpp > I don't think this comment is necessary. This could be from TSocket.cpp too Actually, this specific exception message shows up only when a caller calls throw TTransportException(TTransportException::NOT_OPEN); I grep'ed the thrift library code and there are two files which have the pattern above: TSocketPool.cpp and TSSLSocket.cpp http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: Line 328: return Status::OK(); > Not from this change, but I think we should set client_is_unrecoverable_=fa Done http://gerrit.cloudera.org:8080/#/c/7229/2/tests/custom_cluster/test_rpc_exception.py File tests/custom_cluster/test_rpc_exception.py: PS2, Line 46: execute_query > Not from this change, but change to execute_test_query(). Done -- To view, visit http://gerrit.cloudera.org:8080/7229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8243d4cac93c453e9396b0e24f41e147c8637b8c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
