Alex Behm has posted comments on this change. Change subject: IMPALA-4687: Get Impala working against HBase 2.0 ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7277/1/be/src/exec/hbase-table-scanner.cc File be/src/exec/hbase-table-scanner.cc: Line 407: // necessary). For HBase 2.0, ScannerTimeoutException does not exist, so simple typo: simply Line 411: if (scanner_timeout_ex_cl_ == nullptr) return status; Is there new exception that signals we need to retry? Is the retry not necessary any more? Line 512: // Newer versions of HBase re-create the ResultScanner without throwing this Is "re-create" the right term? I'm not sure how that would work. Do you mean the ResultScanner internally resets its state to automatically retry? Line 514: // code will simply return the error. what is "the error"? http://gerrit.cloudera.org:8080/#/c/7277/1/be/src/exec/hbase-table-scanner.h File be/src/exec/hbase-table-scanner.h: Line 61: /// 1. Scan.setCaching and Scan.setCacheBlocks tolerate the older void return value use () for function/methods, e.g. Scan.setCaching() -- To view, visit http://gerrit.cloudera.org:8080/7277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87610e25c01b3547ec332c6975b61284b6837d27 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
