Dan Hecht has posted comments on this change. Change subject: IMPALA-4687: Get Impala working against HBase 2.0 ......................................................................
Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/7277/3/be/src/exec/hbase-table-scanner.cc File be/src/exec/hbase-table-scanner.cc: PS3, Line 516: // Newer versions of HBase use a heartbeat, so they do not timeout. : // Rather than throwing the ScannerTimeoutException, HBase will reset : // the scanner and retry. For HBase 2.0, the ScannerTimeoutException is : // removed. In these cases, HandleResultScannerTimeout will return the exception : // error message in the status. this comment seems gratuitous to me (already explained in better locations -- here, the caller doesn't really care about this detail and whether timeout can be true or not for the given implementation). i.e. you've already hidden the difference inside HandleResultScannerTimeout(), which has common semantics for 1.0 and 2.0. http://gerrit.cloudera.org:8080/#/c/7277/3/be/src/exec/hbase-table-scanner.h File be/src/exec/hbase-table-scanner.h: PS3, Line 59: supports HBase < 0.95.2 I guess the implication is that 0.95.2 uses the same API as 1.0? -- To view, visit http://gerrit.cloudera.org:8080/7277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87610e25c01b3547ec332c6975b61284b6837d27 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-HasComments: Yes
