Joe McDonnell has posted comments on this change. Change subject: IMPALA-4687: Get Impala working against HBase 2.0 ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7277/3/be/src/exec/hbase-table-scanner.cc File be/src/exec/hbase-table-scanner.cc: PS3, Line 516: // Newer versions of HBase use a heartbeat, so they do not timeout. : // Rather than throwing the ScannerTimeoutException, HBase will reset : // the scanner and retry. For HBase 2.0, the ScannerTimeoutException is : // removed. In these cases, HandleResultScannerTimeout will return the exception : // error message in the status. > this comment seems gratuitous to me (already explained in better locations Good point. Removed. http://gerrit.cloudera.org:8080/#/c/7277/3/be/src/exec/hbase-table-scanner.h File be/src/exec/hbase-table-scanner.h: PS3, Line 59: supports HBase < 0.95.2 > I guess the implication is that 0.95.2 uses the same API as 1.0? Modified the comment to note the reason. This is because we get results via Cell class rather than KeyValue class. -- To view, visit http://gerrit.cloudera.org:8080/7277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87610e25c01b3547ec332c6975b61284b6837d27 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-HasComments: Yes
