Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5514: Add the joint judgment of ldap_password_cmd and ldap ......................................................................
Patch Set 2: (3 comments) Thanks for raising the jira and submitting a quick fix. The fix looks good mostly apart from a few nits. Mind fixing them? http://gerrit.cloudera.org:8080/#/c/7188/2//COMMIT_MSG Commit Message: PS2, Line 7: Add the joint judgment of ldap_password_cmd and ldap Sorry for nitpicking, I don't think judgement is the right word here. How about, "Throw an error when --ldap_password_cmd is used without LDAP auth" ? (Also please update the description below accordingly). PS2, Line 11: nit: Please remove trailing spaces (here and below) http://gerrit.cloudera.org:8080/#/c/7188/2/shell/impala_shell.py File shell/impala_shell.py: PS2, Line 1333: Must use LDAP authentication while retrieving the LDAP password IMO something like "Option --ldap_password_cmd requires using LDAP authentication mechanism (-l)" gives a more detailed description to the end user as to what the actual problem is. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/7188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Donghui Xu <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
