Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-5514: Throw an error when --ldap_password_cmd is used 
without LDAP auth
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

I can run the pre-commit job once you fix the longline. +2'ing since the patch 
is trivial.

http://gerrit.cloudera.org:8080/#/c/7188/3/shell/impala_shell.py
File shell/impala_shell.py:

Line 1333:     print_to_stderr("Option --ldap_password_cmd requires using LDAP 
authentication mechanism (-l)")
long line


-- 
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Donghui Xu <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to