Donghui Xu has posted comments on this change. Change subject: IMPALA-5514: Throw an error when --ldap_password_cmd is used without LDAP auth ......................................................................
Patch Set 3: (3 comments) Thank you for the suggestion. I have modified the code. http://gerrit.cloudera.org:8080/#/c/7188/2//COMMIT_MSG Commit Message: PS2, Line 7: Throw an error when --ldap_password_cmd is used with > Sorry for nitpicking, I don't think judgement is the right word here. How a Done PS2, Line 11: > nit: Please remove trailing spaces (here and below) Done http://gerrit.cloudera.org:8080/#/c/7188/2/shell/impala_shell.py File shell/impala_shell.py: PS2, Line 1333: Option --ldap_password_cmd requires using LDAP authentication m > IMO something like "Option --ldap_password_cmd requires using LDAP authenti Done -- To view, visit http://gerrit.cloudera.org:8080/7188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Donghui Xu <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
