Jim Apple has posted comments on this change. Change subject: Complete guide to important environment variables for build, test, and mini-cluster operations. ......................................................................
Patch Set 1: > (2 comments) > > > > I personally abhor Google docs as they just seem to get lost in > > the > > > Wiki-sea over time. If we are going to take time to document > the > > > various set of environment variables controlling important > > aspects > > > of the build, why not make that accessible to both the internal > > and > > > external developers by including it in the codebase. > > > > > > This is my first draft of the standard build settings. > > > > What about the Wiki, like this page: > > https://cwiki.apache.org/confluence/display/IMPALA/Bootstrapping+an+Impala+Development+Environment+From+Scratch > > Our wikis are pretty nice, and for things like ASAN, totally worth > documenting separately, but for non-major features, keeping this up > to date still requires updating things in two places. In > experience, this isn't something people will do reliably unless > forced. I think we could force at least minimal documentation by > keeping a white-list of exported build variables and enforcing it > with a pre-checkin lint rule. Do you plan to add that lint rule to this patch? -- To view, visit http://gerrit.cloudera.org:8080/7350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16d34cb4fa0c60c5ad6d9c8764cc0ec21c5cb368 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: No
