Tim Armstrong has posted comments on this change. Change subject: Guide to important environment variables for build, test, and mini-cluster operations. ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7350/2/bin/impala-config.sh File bin/impala-config.sh: Line 456: LIBHDFS_OPTS="${LIBHDFS_OPTS}:${IMPALA_HOME}/be/build/debug/service" > mabe safer to put be/build/latest/service ? I agree that it's wrong, and /latest/ is the correct way to point it at that directly, but I was thinking that the wrongness provided evidence that it wasn't actually needed. You're right that we should probably validate it before changing it, so it's a bad idea to tack it onto this change. Line 473: LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:${IMPALA_HOME}/be/build/debug/service" > Agree, but unsure about the combinations of shared / static builds needed t Yeah probably best not to tack it on if we're not confident. -- To view, visit http://gerrit.cloudera.org:8080/7350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16d34cb4fa0c60c5ad6d9c8764cc0ec21c5cb368 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
