Zach Amsden has posted comments on this change. Change subject: Guide to important environment variables for build, test, and mini-cluster operations. ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7350/2/bin/impala-config.sh File bin/impala-config.sh: Line 343: if type nproc >/dev/null 2>&1; then > I used "getconf _NPROCESSORS_ONLN" in infra/python/bootstrap_virtualenv.py. Done PS2, Line 433: nproc > Hmm, should this use $CORES? No, I think we only want to reduce concurrency for tests, which might actually start doing multi-threaded things, but for the build, full steam ahead. Line 456: LIBHDFS_OPTS="${LIBHDFS_OPTS}:${IMPALA_HOME}/be/build/debug/service" > Pretty sure we don't need this, since everything works on a release build. mabe safer to put be/build/latest/service ? Line 473: LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:${IMPALA_HOME}/be/build/debug/service" > Same here. Pretty sure that we don't need to add this to LD_LIBRARY_PATH. Agree, but unsure about the combinations of shared / static builds needed to test this hypothesis. Line 491: alias gerrit-verify-only="${IMPALA_AUX_TEST_HOME}/jenkins/gerrit-verify-only.sh" > We can remove this while we're here too - it's referring to a Cloudera-inte Done -- To view, visit http://gerrit.cloudera.org:8080/7350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16d34cb4fa0c60c5ad6d9c8764cc0ec21c5cb368 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes
