Jim Apple has posted comments on this change. Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7414/1/be/src/gutil/hash/hash.h File be/src/gutil/hash/hash.h: Line 222 > You're right. std::hash template class is specialized between 1 byte and 8 OK, so it looks like you've added it back in. Before we can decide if it should stay or not, let'd understand why it didn't break the build before. Line 278 > You're right. It should make wrong result or corruption. So, do you need it to still exist, and if so, how do you make sure std::hash, which may not be __gnu_cxx::hash, is specialized? -- To view, visit http://gerrit.cloudera.org:8080/7414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06af30fd15acd43a60e3c30af54056c96520b6e9 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-HasComments: Yes