Kim Jin Chul has posted comments on this change. Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7414/1/be/src/gutil/hash/hash.h File be/src/gutil/hash/hash.h: Line 278 > I looked at your comment. I did not respond yet because it is premature for I found the specialized code from 218 to 328 is unused. My conclusion is the code can be removed because of the reason below. I believe there is no logical issue on my change. 1. hash functions are only used in hash_map/hash_set (Checking with the command: git grep __gnu_cxx src) 2. hash_map/hash_set => unordered_map/unordered_set The key type is only 'string'. std::hash<std::string> is specialized in C++11. -- To view, visit http://gerrit.cloudera.org:8080/7414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06af30fd15acd43a60e3c30af54056c96520b6e9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-HasComments: Yes
