Jim Apple has posted comments on this change. Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7414/1/be/src/gutil/hash/hash.h File be/src/gutil/hash/hash.h: Line 222 > I guess the reason is that __gnu_cxx::hash<> was not used anywhere. I didn I think you might be right. Where was it used before your patch? In the hash_set/hash_map definitions? Line 278 > I got it. My idea is that some specializations in __gnu_cxx should be moved My suggestion is to dig into this library and understand the details of what hash functions are used where. As-is, it seems a little bit like you are trying things just to see what seems to work, which is a dangerous way to live in C++. -- To view, visit http://gerrit.cloudera.org:8080/7414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06af30fd15acd43a60e3c30af54056c96520b6e9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-HasComments: Yes
